mirror of
https://github.com/actions/checkout.git
synced 2026-03-19 02:49:07 +00:00
3ff67abc5a
- Kill git process on timeout: use child_process.spawn directly for
timeout-eligible operations so we have a ChildProcess handle to send
SIGTERM (then SIGKILL after 5s). On Windows, SIGTERM is a forced kill
so the SIGKILL fallback is effectively a no-op there.
- Fix timeout:0 not working: replace falsy || coalescion with explicit
empty-string check so that '0' is not replaced by the default '300'.
- Refactor execGit to use an options object instead of 5 positional
parameters, eliminating error-prone filler args (false, false, {}).
- Pass allowAllExitCodes through to execGitWithTimeout so both code
paths have consistent behavior for non-zero exit codes.
- Add settled guard to prevent double-reject when both close and error
events fire on the spawned process.
- Handle null exit code (process killed by signal) as an error rather
than silently treating it as success.
- Capture stderr in error messages for the timeout path, matching the
information level of the non-timeout exec path.
- Log SIGKILL failures at debug level instead of empty catch block.
- Warn on customListeners being ignored in the timeout path.
- Emit core.warning() when invalid input values are silently replaced
with defaults, so users know their configuration was rejected.
- Add input validation in setTimeout (reject negative values).
- Clarify retry-max-attempts semantics: total attempts including the
initial attempt (3 = 1 initial + 2 retries).
- Remove Kubernetes probe references from descriptions.
- Use non-exhaustive list (e.g.) for network operations in docs to
avoid staleness if new operations are added.
- Add tests for timeout/retry input parsing (defaults, timeout:0,
custom values, invalid input with warnings, backoff clamping) and
command manager configuration (setTimeout, setRetryConfig, fetch).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| git-auth-helper.test.ts | ||
| git-command-manager.test.ts | ||
| git-directory-helper.test.ts | ||
| git-version.test.ts | ||
| input-helper.test.ts | ||
| modify-work-tree.sh | ||
| override-git-version.cmd | ||
| override-git-version.sh | ||
| ref-helper.test.ts | ||
| retry-helper.test.ts | ||
| url-helper.test.ts | ||
| verify-basic.sh | ||
| verify-clean.sh | ||
| verify-fetch-filter.sh | ||
| verify-fetch-tags.sh | ||
| verify-lfs.sh | ||
| verify-no-unstaged-changes.sh | ||
| verify-side-by-side.sh | ||
| verify-sparse-checkout-non-cone-mode.sh | ||
| verify-sparse-checkout.sh | ||
| verify-submodules-false.sh | ||
| verify-submodules-recursive.sh | ||
| verify-submodules-true.sh | ||
| verify-worktree.sh | ||